-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits #2251
extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits #2251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR could you add a test?
@JoviDeCroock Shall i build a new test file for it or shall i extend the existing test/svg.test.js file ? |
Oh man i need help. Why are now the checks and the Pica CI failed ? |
Failing test and failing coverage |
@JoviDeCroock mistake. i revert it to color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for contributing this!
That sounds good to me @JoviDeCroock. What are my next steps to close this PR ? |
@friebe I'll wait for @marvinhagemeister or @developit to also give it an approval. I see you have disabled the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 👍 Looks good to me 💯
Hey @friebe When you get time could you update your branch or give us the right to do so by ticking "allow edit from maintainers" |
What does it mean check "compressed Size / build" fail. |
It can't access your branch, pinging @developit (you have a blocker with requested changes and the compressed-size plugin can't access forked repo's) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! sorry for the slow response.
(aside: the size bot no longer fails PRs when it can't comment, it'll be a while before Github has a fix for the fork permissions thing)
🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN:
|
…reactjs#2251) * extends the CAMEL_PROPS regex to accept svg attribut clipPathUnits * remove unnecessary trailing pipe in CAMEL_PROPS regex * add test for svg attribute (clipPathUnits) manipulation * adjust CAMEL_PROPS regex to passes tests * refactor svg.test to manipulation attributePathUnits * remove "clip" from CAMEL_PROPS regex Co-authored-by: Jason Miller <developit@users.noreply.github.com>
issue #2036